[Appdir] Thumbnail recoloring #3776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metOverview.module.css
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the thumbnail rendering by recoloring images based on status, migrating from NextImage and custom SVG fallbacks to a new utility component, ImageAsThemedSvg.
- Replaces NextImage with ImageAsThemedSvg in DesignsystemetOverviewCard
- Updates DesignsystemetPage and DesignsystemetThumbnail to use the new thumbnail URL and rendering logic
- Introduces a new utility component for fetching and sanitizing SVG images with dynamic color replacements
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| aksel.nav.no/website/app/dev/(designsystemet)/_ui/overview/DesignsystemetOverview.tsx | Replaces NextImage/FallbackSvg with ImageAsThemedSvg and re-arranges layout for status tag positioning |
| aksel.nav.no/website/app/dev/(designsystemet)/_ui/DesignsystemetPage.tsx | Passes thumbnailUrl to DesignsystemetThumbnail and adds data attributes for styling |
| aksel.nav.no/website/app/dev/(designsystemet)/_ui/Designsystemet.thumbnail.tsx | Refactors thumbnail component to conditionally render SVG based on thumbnailUrl |
| aksel.nav.no/website/app/_ui/image-as-svg/ImageAsSvg.tsx | Adds a new async component for fetching, recoloring, and sanitizing SVG images using DOMPurify |
Files not reviewed (3)
- aksel.nav.no/website/app/_ui/image-as-svg/ImageAsSvg.module.css: Language not supported
- aksel.nav.no/website/app/dev/(designsystemet)/_ui/Designsystemet.module.css: Language not supported
- aksel.nav.no/website/app/dev/(designsystemet)/_ui/overview/DesignsystemetOverview.module.css: Language not supported
Comments suppressed due to low confidence (1)
aksel.nav.no/website/app/_ui/image-as-svg/ImageAsSvg.tsx:7
- The async component ImageAsThemedSvg is used directly within JSX in other components. Please ensure that its asynchronous behavior is properly handled by its consumers (e.g., by using server components or Suspense) to prevent potential rendering issues.
async function ImageAsThemedSvg({
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Colors thumbnail based on status
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")