📝 Deprecate ConfirmationPanel #3789
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 231930e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the ConfirmationPanel component by adding a deprecation notice to its JSDoc and updating the associated documentation references.
- Added a deprecation tag in ConfirmationPanel.tsx with a new documentation link suggesting to use Checkbox instead.
- Introduced a changeset file documenting the deprecation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| @navikt/core/react/src/form/confirmation-panel/ConfirmationPanel.tsx | Added a deprecation notice in the JSDoc comment. |
| .changeset/chatty-things-yawn.md | Added a changeset entry indicating deprecation. |
Co-authored-by: Copilot <[email protected]>
Storybook demo / Chromatic2bbb57596 | 91 components | 135 stories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/navikt/team-aksel/issues/707
https://aksel.nav.no/komponenter/legacy/confirmationpanel#99622218e7f0
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")