🚚 Update icons to handle updated fill-color from Figma. #3790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the icons to handle the new fill-color defined in Figma. Key changes include:
- Bumping the "updated_at" dates in multiple YAML icon files.
- Replacing the hard-coded color "#23262A" with "#202733" in icon parsing, tests, and configuration.
- Updating documentation in CONTRIBUTING.md to reflect the new color guidelines.
Reviewed Changes
Copilot reviewed 1845 out of 1845 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| @navikt/aksel-icons/icons/*.yml | Updated metadata ("updated_at") to reflect the new update date. |
| @navikt/aksel-icons/config/parse-svg.js | Changed the hard-coded color replacement to the new color. |
| @navikt/aksel-icons/tests/validate-svg.test.ts | Updated expected stroke color for SVG validation. |
| @navikt/aksel-icons/tests/validate-svg-parsing.test.ts | Updated expected fill colors in SVG parsing tests. |
| @navikt/aksel-icons/CONTRIBUTING.md | Updated fill color instructions to match the new design. |
| @navikt/aksel-icons/.svgrrc.js | Updated SVGR configuration to use the new fill color. |
Storybook demo / Chromatic13e75c8b3 | 91 components | 135 stories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/navikt/team-aksel/issues/736