Introduce separate types for different keys #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced types for public and private expanded blinded keys that wrap byte array representation of those keys. Use those types instead of raw byte arrays. This should improve code clarity and potentially, safety.
Introduced NTorOnionKey type that wraps byte array and use it where applicable. Use Ed25519PublicKeyParameters instead of byte array for IntroductionPointInfo.MasterPublicKey. This should improve code clarity and potentially, safety.
Introduced IdentityKey type that wraps byte array and use it where applicable. This should improve code clarity and potentially, safety.
Renamed OnionKey to NTorOnionKey in IntroductionPointInfo.
Make NTorOnionKey type validate key length on creation.
Make IdentityKey type validate key length on creation. Improve error message for wrong key length.
Renamed ExpandedBlindedPublicKey to BlindedPublicKey.
Renamed ExpandedBlindedPrivateKey to Ed25519PrivateKey, which now can be either NormalEd25519PrivateKey or ExpandedEd25519PrivateKey. Implemented length checks for both. Renamed BlindedPublicKey to ED25519PublicKey.
Use BouncyCastle types for Ed25519PrivateKey.NormalEd25519 and ED25519PublicKey.
aarani
reviewed
Jun 5, 2023
webwarrior-ws
force-pushed
the
pr/key-types
branch
from
4ce49fa to
9edc571
Compare
Renamed IdentityKey type to Fingerprint as technically this is the digest of identity key.
webwarrior-ws
force-pushed
the
pr/key-types
branch
from
9edc571 to
7e325e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce separate types for different keys instead of using byte array everywhere.