Track Java version in cluster manifest #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oversight on my part.
add-slavesshould not have or need the ability to specify a Java version. It should source it from the cluster manifest, guaranteeing that all added slaves have the same configuration as the existing cluster.This matches the behavior of
add-slavesin regards to picking the appropriate version of Hadoop or Spark to install on the new nodes.Potential future improvement: Make Java a "service" like Hadoop and Spark, and reuse the cluster provisioning abstractions already built for them. Will need to build a way to express service dependencies (e.g. Spark depends on Java) so they get installed in the correct order.
Follow-up to #316.