Send the MXP start command so strict clients like MUSHclient activate MXP. - #13
Merged
Conversation
powerje
force-pushed
the
mxp-start-subnegotiation
branch
from
August 12, 2026 00:00
02f0bf9 to
b4b3ff3
Compare
powerje
force-pushed
the
mxp-start-subnegotiation
branch
from
August 12, 2026 00:01
b4b3ff3 to
af03fae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server was treating the client's IAC DO MXP as full activation and immediately switching to escaped, tagged output, but the MXP handshake has a third step: after WILL/DO, the server must send the start command
IAC SB MXP IAC SE. MUSHclient's default "Use MXP: on command" setting waits for exactly that subnegotiation before it turns its parser on, so it displayed everything literally. Mudlet-family clients activate on WILL/DO alone, which is why this never showed up in testing.This sends the start command in
processDoMxp()ahead of theESC[7zlocked-default line mode (a client that only starts parsing at the start command would otherwise miss the lock), and resends it fromreassertMXP()on the copyover path. Same change mirrored into the C oracle and Kotlin implementations, with tests asserting the start command is sent, ordered before the lock, and not re-emitted on a duplicate DO.