Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the ground work for testing the integration and functionality support of the NNsight.VLLM model.
To run the tests in question:
pytest tests/test_vllm.py --tp <tp>
Use the argument
--tp
to specify the engine argumenttensor_parallel_size
on the VLLM model, defaults to1
. If--tp > 1
, all the tests will be ran within the distributed environment of the model and will also run additional tests exclusively related to that functionality.Future Work:
Some of the tests included in this PR require further improvements to pass the expected behavior. For the time being, these tests are commented out and the goal is continue the efforts to reach a full working integration of vllm, with minimal change to the user's NNsight experience. Here's a list of future improvements related to these tests: