Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbox Features #7

Closed
wants to merge 27 commits into from
Closed

Toolbox Features #7

wants to merge 27 commits into from

Conversation

cadentj
Copy link
Member

@cadentj cadentj commented Nov 18, 2023

Thoughts on correct way to implement toolbox:

  • Folder per tool (optim/interventions/lens)?
  • Is it good to call .save() in an external optim class? Should the user have 100% say over when things are saved?
    • This just makes it a little weird because logit lens would return a list of proxies and that can't be .save() (maybe this is a future feature)

Lens

Logit Lens

  • How many features should we add to logit lens? Should it just return logits? In general how simple should tools be?
    • If it returns probs/logits over certain tokens, should that be within the main loop or abstracted as a separate function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants