Skip to content

Include example for spot instance node group config on AWS #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaronkanzer
Copy link

@aaronkanzer aaronkanzer commented May 6, 2025

Reference Issues or PRs

Documentation follow-up for nebari-dev/nebari#3049

Cc @satra @kabilar @yarikoptic @asmacdo

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

netlify bot commented May 6, 2025

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 04296d4
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/681a47442749bc0008783581
😎 Deploy Preview https://deploy-preview-576--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aaronkanzer! I just left a small suggestion to update the key and value in the example, based on the changes introduced in nebari-dev/nebari#3069.

taints:
gpu: false
single_subnet: false
capacity_type: "SPOT"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
capacity_type: "SPOT"
spot: true

@kabilar
Copy link

kabilar commented Jun 17, 2025

Hi @marcelovilla, Aaron may not have time to look at this PR, so I have filed #584. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo 📬
Development

Successfully merging this pull request may close these issues.

3 participants