-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update google terraform version, replace container registry by artifact registry #2902
Merged
dcmcand
merged 8 commits into
nebari-dev:main
from
swapkh91:fix/2894-gcp-migrate-to-artifact-registry
Feb 7, 2025
Merged
update google terraform version, replace container registry by artifact registry #2902
dcmcand
merged 8 commits into
nebari-dev:main
from
swapkh91:fix/2894-gcp-migrate-to-artifact-registry
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dcmcand @viniciusdc i've opened the PR as per my novice understanding, please review :) |
Thanks, @swapkh91, for the PR! We will include it in our next release, scheduled for February |
dcmcand
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks for this @swapkh91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact: high 🟥
This issue affects most of the nebari users or is a critical issue
needs: review 👀
This PR is complete and ready for reviewing
provider: GCP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Fixes #2894
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
module.registry-jupyterhub
hashicorp/google
version instages/02-infrastructure/gcp/versions.tf
andstages/01-terraform-state/gcp/main.tf
to6.14.1
stages/02-infrastructure/gcp/modules/registry/main.tf
tonebari deploy -c nebari-config.yaml --disable-render
Any other comments?