Skip to content

Fix git.root failing git repo detection: Set rootDir as working dir for git execs #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barooi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix git.root failing git repo detection: Set rootDir as working dir for git execs #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/groovy/nebula/plugin/release/git/command/GitReadCommand.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ abstract class GitReadCommand implements ValueSource<String, GitCommandParameter
List<String> commandLineArgs = ["git", "--git-dir=${rootDir.absolutePath}/.git".toString(), "--work-tree=${rootDir.absolutePath}".toString()]
commandLineArgs.addAll(args)
execOperations.exec {
it.setWorkingDir(rootDir.absolutePath)
it.setCommandLine(commandLineArgs)
it.standardOutput = output
it.errorOutput = error
Expand All @@ -45,6 +46,7 @@ abstract class GitReadCommand implements ValueSource<String, GitCommandParameter
List<String> commandLineArgs = ["git", "--git-dir=${rootDir.absolutePath}/.git".toString(), "--work-tree=${rootDir.absolutePath}".toString()]
commandLineArgs.addAll(args)
execOperations.exec {
it.setWorkingDir(rootDir.absolutePath)
it.setCommandLine(commandLineArgs)
it.standardOutput = output
it.errorOutput = error
Expand Down
1 change: 1 addition & 0 deletions src/main/groovy/nebula/plugin/release/git/command/GitWriteCommandsUtil.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ class GitWriteCommandsUtil implements Serializable {
List<String> commandLineArgs = ["git", "--git-dir=${rootDir.absolutePath}/.git".toString(), "--work-tree=${rootDir.absolutePath}".toString()]
commandLineArgs.addAll(args)
execOperations.exec {
it.setWorkingDir(rootDir.absolutePath)
it.ignoreExitValue = true
it.setCommandLine(commandLineArgs)
it.standardOutput = output
Expand Down