Miscellaneous fixes and improvements before release#21
Merged
MassimilianoLattanzio merged 5 commits intomainfrom Jan 13, 2026
Merged
Conversation
Adds a data-controller wrapper div around the existing template content to enable Stimulus JavaScript framework integration.
Standardizes logging method to use the more common console.log instead of console.info.
There was a problem hiding this comment.
Pull request overview
This PR includes pre-release refinements to generator templates and documentation. The changes improve Stimulus integration, simplify controller registration, and document theme compatibility.
Changes:
- Refactored Stimulus controller template to use inline class syntax instead of separate class declaration
- Added wrapping div with
data-controllerattribute to all generated Liquid templates for better Stimulus integration - Updated console output methods and enhanced documentation with tested theme information
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| generators/index.js.tt | Changed console.info to console.log for consistency |
| generators/controller.js.tt | Simplified controller registration using inline class syntax |
| generators/%type%.liquid.tt | Added Stimulus controller wrapper div to template |
| README.md | Added "Tested With" section and clarified TODO items |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Tested With | ||
|
|
||
| - [Skeleton Theme](https://github.com/Shopify/skeleton-theme) | ||
| - [Horizon Theme](https://github.com/Shopify/horizon) |
There was a problem hiding this comment.
The GitHub repository URL for "Horizon Theme" appears to reference a repository that may not exist. Shopify's official reference theme is typically "Dawn" (https://github.com/Shopify/dawn). Please verify that this repository exists and is the correct reference.
Suggested change
| - [Horizon Theme](https://github.com/Shopify/horizon) | |
| - [Dawn Theme](https://github.com/Shopify/dawn) |
MassimilianoLattanzio
deleted the
massimilianolattanzio/misc-fixes-before-release
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes several small improvements and fixes in preparation for the next release.
Changes
Generator Templates
divwithdata-controllerattribute for better Stimulus integrationconsole.logfor better consistencyDocumentation