Updated src/ - Clean npm lint test#4
Merged
Frenzy-code merged 4 commits intomainfrom Aug 31, 2025
Merged
Conversation
xd lol the problem was with the wrapper
Collaborator
Author
|
I edited fibRoute.ts to handle edge cases and type handling. |
Collaborator
Author
|
It used to call |
nejail
reviewed
Aug 31, 2025
| // Endpoint for querying the fibonacci numbers | ||
|
|
||
| const fibonacci = require("./fib"); | ||
| import { fibonacci } from "./fib"; |
Owner
There was a problem hiding this comment.
Good way of fixing the error of the import that made the lint run
nejail
reviewed
Aug 31, 2025
Owner
nejail
left a comment
nejail
left a comment
There was a problem hiding this comment.
Overall, the code looks good, and with the lint test it passes every test needed, should be merged to main!
Collaborator
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xd lol the problem was with the wrapper