Conversation
Collaborator
Author
|
I edited fibRoutes.ts file to handle what the errors stated, and fixed the import problem. Then tested the code and made sure that it passes all the tests. |
Frenzy-code
approved these changes
Aug 31, 2025
Collaborator
Frenzy-code
left a comment
Frenzy-code
left a comment
There was a problem hiding this comment.
Looks good to me, I don't think we needed to replace the equality check but overall pretty good as it just werks.
please go over the comments and review them one by one.
| if (n < 0) { | ||
| return -1; | ||
| } else if (n == 0) { | ||
| } else if (n === 0) { |
Collaborator
There was a problem hiding this comment.
you don't really need the strict equality here since we know that n is of type Number
| let result = `fibonacci(${num}) is ${fibN}`; | ||
| export default function fibRoute(req: Req, res: Res): void { | ||
| const numParam = req.params.num; // no more unsafe access | ||
| if (!(typeof numParam === "string" )) { |
| } | ||
|
|
||
| const retVal = fibonacci(n); | ||
| let result = ""; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.