-
Notifications
You must be signed in to change notification settings - Fork 64
Graph types as direct PR #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Graph types as direct PR #1406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the show constraint command results lost their new columns as the vector constraint rows were added :(
Co-authored-by: Therese Magnusson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments on the updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answering the classification questions as well as adding the vector property type constraints to the setup
Co-authored-by: Therese Magnusson <[email protected]>
This PR includes documentation updates New pages:
Updated pages: |
| 33 | "movie_title" | "NODE_PROPERTY_TYPE" | "NODE" | ["Movie"] | ["title"] | NULL | "independent" | NULL | "STRING" | NULL | "CREATE CONSTRAINT `movie_title` FOR (n:`Movie`) REQUIRE (n.`title`) IS :: STRING" | | ||
| 17 | "node_uniqueness_param" | "NODE_PROPERTY_UNIQUENESS" | "NODE" | ["Book"] | ["prop1"] | NULL | "undesignated" | "node_uniqueness_param" | NULL | {indexConfig: {}} | "CREATE CONSTRAINT `node_uniqueness_param` FOR (n:`Book`) REQUIRE (n.`prop1`) IS UNIQUE" | | ||
| 2 | "node_vector_constraint" | "NODE_PROPERTY_TYPE" | "NODE" | ["Movie"] | ["embedding"] | NULL | "" | NULL | "VECTOR<INTEGER32 NOT NULL>(42)" | NULL | "CREATE CONSTRAINT `node_vector_constraint` FOR (n:`Movie`) REQUIRE (n.`embedding`) IS :: VECTOR<INTEGER32 NOT NULL>(42)" | | ||
| 2 | "node_vector_constraint" | "NODE_PROPERTY_TYPE" | "NODE" | ["Movie"] | ["embedding"] | NULL | "independent" | NULL | "VECTOR<INTEGER32 NOT NULL>(42)" | NULL | "CREATE CONSTRAINT `node_vector_constraint` FOR (n:`Movie`) REQUIRE (n.`embedding`) IS :: VECTOR<INTEGER32 NOT NULL>(42)" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vector rows are not aligned along the columns in this table, might need to be updated (might be that the others need to be extended to fit the vector ones as well, but at least some is on the vector lines to fix as well)
this is also likely to be an issue for the other result tables and not just this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what I would start with would be to align all rows for the name (adding a space/dash to the ones that need it and not remove the one from the node vector one), then remove the spacing after "independent"
on the two vector ones to align there, and then check if the ends need some update to align all the rows with the widest column (and checking that all column lines are then aligned for all rows)
This should be the same as #1391
The changes from #1325 have been incorporated.
I was unable to push to the fork 1391 was created from, that's why i raised a new PR