-
Notifications
You must be signed in to change notification settings - Fork 83
Replace all links to /cypher-manual/25/ to link to /current/ #2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/current/ to link to /5/
715f751 to
dd762fb
Compare
NataliaIvakina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I didn't find any mistakes: all current are redirected to 5, and all 25 are redirected to current.
However, I'm wondering if we need to specify Cypher version in link texts, to make it clear for users that they will go to the Cypher 5 Manual or Cypher 25 Manual.
I also think, it would be nice if @stefano-ottolenghi reviews this PR (from the Cypher's side).
modules/ROOT/pages/authentication-authorization/limitations.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/scalability/sharded-property-databases/data-ingestion.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/introduction.adoc
Outdated
| | {check-mark} | ||
|
|
||
| | link:{neo4j-docs-base-uri}/cypher-manual/current/introduction/cypher-overview/[Cypher graph query language] | ||
| | link:{neo4j-docs-base-uri}/cypher-manual/5/introduction/cypher-overview/[Cypher graph query language] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, should we update this entry by adding info about Cypher 25?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, all these should link to current as they are not Cypher 5 specific.
modules/ROOT/pages/introduction.adoc
Outdated
| | {check-mark} | ||
|
|
||
| | link:{neo4j-docs-base-uri}/cypher-manual/current/introduction/cypher-overview/[Cypher graph query language] | ||
| | link:{neo4j-docs-base-uri}/cypher-manual/5/introduction/cypher-overview/[Cypher graph query language] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | link:{neo4j-docs-base-uri}/cypher-manual/5/introduction/cypher-overview/[Cypher graph query language] | |
| | link:{neo4j-docs-base-uri}/cypher-manual/5/introduction/cypher-overview/[Cypher 5] - Graph query language |
| | link:{neo4j-docs-base-uri}/cypher-manual/5/introduction/cypher-overview/[Cypher graph query language] | ||
| | {check-mark} | ||
| | {check-mark} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| label:new[Introduced in 2025.06] link:{neo4j-docs-base-uri}/cypher-manual/current/introduction/cypher-overview/[Cypher 25]
| {check-mark}
| {check-mark}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page also. It's about Cypher in general, not a specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I should reconsider the links to Cypher 5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we should mention only one Cypher version which is 25. In 2025.01-2025.05, you have only Cypher 5.
IMO, we need to list here two Cypher versions -- 5 and 25.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't pushed my new edits.
modules/ROOT/pages/cypher-shell.adoc
Outdated
| For help on cypher please visit: | ||
| https://neo4j.com/docs/cypher-manual/current/ | ||
| https://neo4j.com/docs/cypher-manual/5/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And fix this one. 😄
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
) Co-authored-by: Natalia Ivakina <[email protected]>
…2743) Co-authored-by: Natalia Ivakina <[email protected]>
No description provided.