Skip to content

Conversation

@gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Dec 13, 2024

net5.0 does not seem to be used.
Microsoft.Bcl.AsyncInterfaces 5.0.0 gives a warning as per #817.
System.ValueTuple is already included.
Microsoft.Bcl.AsyncInterfaces is only needed for netstandard2.0.

@gpetrou
Copy link
Contributor Author

gpetrou commented Dec 14, 2024

@RichardIrons-neo4j how can I see the Teamcity build logs?

@RichardIrons-neo4j
Copy link
Contributor

Hi @gpetrou, and thank you for contributing to the code base!

The build is failing because to be able to merge your changes we will need a signed CLA from you. TeamCity checks a whitelist of users that have signed and fails the build if the PR comes from a user not on the list.

See http://neo4j.com/developer/cla/ for further information.

Additional information on contributing code can be found at
http://neo4j.com/developer/contributing-code/

@RichardIrons-neo4j
Copy link
Contributor

Hi @gpetrou, and thank you for contributing to the code base!

The build is failing because to be able to merge your changes we will need a signed CLA from you. TeamCity checks a whitelist of users that have signed and fails the build if the PR comes from a user not on the list.

See http://neo4j.com/developer/cla/ for further information.

Additional information on contributing code can be found at http://neo4j.com/developer/contributing-code/

Never mind, I've just foundf your CLA. I'll get on with adding you to the whitelist.

@gpetrou gpetrou force-pushed the RemovePackageReferences branch from 5c793cc to a96c77c Compare February 1, 2025 06:10
@gpetrou
Copy link
Contributor Author

gpetrou commented Feb 9, 2025

@RichardIrons-neo4j could we merge this one now?

Copy link
Contributor

@RichardIrons-neo4j RichardIrons-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

@RichardIrons-neo4j RichardIrons-neo4j merged commit cfff47c into neo4j:5.0 Feb 10, 2025
5 checks passed
@gpetrou gpetrou deleted the RemovePackageReferences branch February 10, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants