Skip to content

Refactor project configurations to remove 'ReleaseSigned' and sign the 'Release' build instead #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 6.x
Choose a base branch
from
Open

Refactor project configurations to remove 'ReleaseSigned' and sign the 'Release' build instead #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09228ad
Refactor project configurations to remove 'ReleaseSigned' and sign th…
RichardIrons-neo4j Nov 20, 2025
0d82618
Add 'Testkit' configuration for projects and update build script
RichardIrons-neo4j Nov 20, 2025
528ad11
log command line
RichardIrons-neo4j Nov 20, 2025
acafcbd
Update project files to target .NET 10.0 and add necessary package re…
RichardIrons-neo4j Nov 21, 2025
337bf18
Update Dockerfile to use .NET SDK 10.0 and install .NET runtime 9.0
RichardIrons-neo4j Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Neo4j.Driver/Neo4j.Driver.Reactive/Neo4j.Driver.Reactive.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\common.props"/>
<PropertyGroup>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>
<AssemblyName>Neo4j.Driver.Reactive</AssemblyName>
<PackageId>Neo4j.Driver.Reactive$(PackageIdSuffix)</PackageId>
<Authors>Neo4j</Authors>
Expand All @@ -19,11 +19,18 @@
<GenerateNeutralResourcesLanguageAttribute>false</GenerateNeutralResourcesLanguageAttribute>
<GenerateAssemblyVersionAttribute>true</GenerateAssemblyVersionAttribute>
<GenerateAssemblyFileVersionAttribute>true</GenerateAssemblyFileVersionAttribute>
<Configurations>Debug;Release;ReleaseSigned;DebugDelaySigned</Configurations>
<Configurations>Debug;Release;DebugDelaySigned;Testkit</Configurations>
<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\Neo4j.Driver.Reactive.xml</DocumentationFile>
<RootNamespace>Neo4j.Driver</RootNamespace>
<Version>6.0.0</Version>
<LangVersion>default</LangVersion>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<Optimize Condition=" '$(Optimize)' == '' ">true</Optimize>
<SignAssembly>true</SignAssembly>
<DelaySign>false</DelaySign>
<AssemblyOriginatorKeyFile>..\neo4j.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0"/>
Expand Down
11 changes: 9 additions & 2 deletions Neo4j.Driver/Neo4j.Driver.Simple/Neo4j.Driver.Simple.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\common.props"/>
<PropertyGroup>
<TargetFrameworks>net8.0;net9.0</TargetFrameworks>
<TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>
<PackageId>Neo4j.Driver.Simple$(PackageIdSuffix)</PackageId>
<Authors>Neo4j</Authors>
<Description>Synchronous extensions for the official .NET driver.</Description>
Expand All @@ -15,11 +15,18 @@
<GenerateNeutralResourcesLanguageAttribute>false</GenerateNeutralResourcesLanguageAttribute>
<GenerateAssemblyVersionAttribute>true</GenerateAssemblyVersionAttribute>
<GenerateAssemblyFileVersionAttribute>true</GenerateAssemblyFileVersionAttribute>
<Configurations>Debug;Release;ReleaseSigned;DebugDelaySigned</Configurations>
<Configurations>Debug;Release;DebugDelaySigned;Testkit</Configurations>
<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\Neo4j.Driver.Simple.xml</DocumentationFile>
<RootNamespace>Neo4j.Driver</RootNamespace>
<Version>6.0.0</Version>
<LangVersion>default</LangVersion>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<Optimize Condition=" '$(Optimize)' == '' ">true</Optimize>
<SignAssembly>true</SignAssembly>
<DelaySign>false</DelaySign>
<AssemblyOriginatorKeyFile>..\neo4j.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0"/>
Expand Down
6 changes: 6 additions & 0 deletions Neo4j.Driver/Neo4j.Driver.Tests.BenchkitBackend/Neo4j.Driver.Tests.BenchkitBackend.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,18 @@
<ImplicitUsings>enable</ImplicitUsings>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<LangVersion>default</LangVersion>
<Configurations>Debug;Release;Testkit</Configurations>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
<NoWarn>1701;1702;1591;CS1591</NoWarn>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Testkit' ">
<Optimize Condition=" '$(Optimize)' == '' ">true</Optimize>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Autofac" Version="8.0.0"/>
<PackageReference Include="Autofac.Extensions.DependencyInjection" Version="9.0.0"/>
Expand Down
15 changes: 13 additions & 2 deletions Neo4j.Driver/Neo4j.Driver.Tests.Integration/Neo4j.Driver.Tests.Integration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\common.props"/>
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<IsPackable>false</IsPackable>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<GenerateProgramFile>false</GenerateProgramFile>
<Configurations>Debug;Release;ReleaseSigned;DebugDelaySigned</Configurations>
<Configurations>Debug;Release;DebugDelaySigned;Testkit</Configurations>
<GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
<GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
<GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
Expand All @@ -16,6 +16,14 @@
<GenerateAssemblyVersionAttribute>true</GenerateAssemblyVersionAttribute>
<GenerateAssemblyFileVersionAttribute>true</GenerateAssemblyFileVersionAttribute>
<RootNamespace>Neo4j.Driver.IntegrationTests</RootNamespace>
<Platforms>AnyCPU</Platforms>
<LangVersion>default</LangVersion>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<Optimize Condition=" '$(Optimize)' == '' ">true</Optimize>
<SignAssembly>true</SignAssembly>
<DelaySign>false</DelaySign>
<AssemblyOriginatorKeyFile>..\neo4j.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>
<ItemGroup>
<Content Include="App.config"/>
Expand All @@ -24,8 +32,11 @@
<PackageReference Include="Microsoft.Reactive.Testing" Version="5.0.0"/>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3"/>
<PackageReference Include="Moq" Version="4.20.69"/>
<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
<PackageReference Include="Portable.BouncyCastle" Version="1.8.8"/>
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<PackageReference Include="System.Reactive" Version="5.0.0"/>
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
<PackageReference Include="TeamCity.VSTest.TestAdapter" Version="1.0.23"/>
<PackageReference Include="xunit" Version="$(XunitVersion)"/>
<PackageReference Include="xunit.runner.console" Version="$(XunitVersion)"/>
Expand Down
9 changes: 8 additions & 1 deletion Neo4j.Driver/Neo4j.Driver.Tests.TestBackend/Neo4j.Driver.Tests.TestBackend.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,15 @@
<TargetFramework>net8.0</TargetFramework>
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
<Configurations>Debug;Release;ReleaseSigned;DebugDelaySigned</Configurations>
<Configurations>Debug;Release;DebugDelaySigned;Testkit</Configurations>
<LangVersion>default</LangVersion>
<Platforms>AnyCPU</Platforms>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<Optimize Condition=" '$(Optimize)' == '' ">true</Optimize>
<SignAssembly>true</SignAssembly>
<DelaySign>false</DelaySign>
<AssemblyOriginatorKeyFile>..\neo4j.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading