LangChain Compability Restored #442
Conversation
| return_context = False | ||
| if isinstance(self.llm, LLMInterface): | ||
| warnings.warn( | ||
| "The default value of 'return_context' will change from 'False'" |
There was a problem hiding this comment.
These changes seem to be related to line length only, are there made on purpose? (asking because I know Nathalie had some issues about this in the past)
There was a problem hiding this comment.
True, pylint was warning about that line is too long. Autolinter in my ide splitted this line to many lines. I can revert them back if you think it may cause any issue.
There was a problem hiding this comment.
It's just that the next person pushing to the repo will have to make the opposite change, so we should agree on a convention. Is this something we should add to a config file in the repo?
| input: List[LLMMessage], | ||
| ) -> LLMResponse: ... | ||
|
|
||
| @overload # type: ignore[no-overload-impl] |
There was a problem hiding this comment.
Do you know why we need these two type ignore comments: # type: ignore[no-overload-impl] and later # type: ignore[no-redef]?
There was a problem hiding this comment.
seems like a mypy bug. alternatively we can move overload definitions to same file with pyi extension but it may make repo complexer.
2 participants
Description
The additional arguments we previously introduced to the invoke function in LLMInterface broke compatibility with LangChain. This change introduces a new
LLMInterfaceV2contract that is fully compatible with LangChain while maintaining backward compatibility. If any users have implemented the old LLMInterface manually, their implementations will continue to work without modification.Resolves #383
Type of Change
Complexity
Moderate. Even though a new contract provided, the old contact is still valid to offer backward compability.
Complexity:
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):