Feat/mcp server configuration #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant Project/Global section headers, display scope via badge on each card - Optimize tool display: show only first 3 tools with simplified names - Remove bottom action buttons bar for cleaner interface - Improve form spacing and typography (text-sm -> text-xs, reduce gaps) - Enhance dialog centering and badge destructive variant styling - Center settings page content with mx-auto This aligns with preference for concise, intuitive UI with reduced visual noise.
- Remove unused React import in MCPPanel - Use import type for React imports (better tree-shaking) - Fix array index as key issue in MCPServerList (use tool name instead) - Reorganize imports following Biome standards - All changes validated with Biome linter and build successfully
- Make type field required for stdio and http configs - Make args field required for stdio config - Remove deprecated timeout field from all config types - Align type definitions with CLI implementation This change improves type safety and removes unused fields.
- Replace optimistic updates with event-driven state updates - Simplify buildServerList function with direct data mapping - Add explicit error handling and user feedback with toast notifications - Remove duplicate error handling in MCPServerForm - Clear loading states properly on both success and error cases - Fix TypeScript type error: change args from undefined to empty array
- Replace mcp.updateConfig/removeConfig with Load→Modify→Write pattern - Use existing config.set handler for all MCP configuration operations - Add explicit loadServers() calls to ensure UI state sync - Enhance MCPServerForm validation for stdio arguments - Remove obsolete type definitions from nodeBridge.types.ts - Comment out debug logging in store.tsx - Update design documentation to reflect simplified architecture This change simplifies the codebase by reusing existing infrastructure instead of creating MCP-specific configuration handlers.
- Remove mcp.statusChanged event subscription - Remove handleStatusChangeRef and stableHandleStatusChange - Remove unused useRef import - Rely on loadServers() for status updates after operations - Align with backend removal of emitMcpStatusChange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mcp 配置页面及其相关逻辑