fix(renderer): honor nested fence lengths#1704
Merged
1 commit merged intoMay 5, 2026
Merged
Conversation
4daa238
Michaelyklam
pushed a commit
to Michaelyklam/hermes-webui
that referenced
this pull request
May 5, 2026
Michaelyklam
added a commit
to Michaelyklam/hermes-webui
that referenced
this pull request
May 5, 2026
10 PRs (3 surfaces additions, 7 fixes): - nesquena#1644 model picker chip + group count (@bergeouss, closes nesquena#1425) - nesquena#1684 update network failures UX (@Michaelyklam, closes nesquena#1321) - nesquena#1685 Codex spark models (@Michaelyklam, closes nesquena#1680) - nesquena#1689 normalize profile base homes (@Michaelyklam, refs nesquena#749) - nesquena#1693 adaptive title refresh deadlock (@ai-ag2026) - nesquena#1701 normalize update banner URL (@Michaelyklam, closes nesquena#1691) - nesquena#1702 workspace double-click rename (@Michaelyklam, closes nesquena#1698) - nesquena#1703 cache invalidation on auth-store drift (@Michaelyklam, closes nesquena#1699) - nesquena#1704 markdown fence lengths (@Michaelyklam, closes nesquena#1696) - nesquena#1706 multi-image paste fix (@Michaelyklam, closes nesquena#1697) Tests: 4477 → 4503 (+26). Opus: SHIP, 7/7 verification clean. Co-authored-by: Michael Lam <Michaelyklam1@gmail.com> Co-authored-by: ai-ag2026 <noreply@github.com> Co-authored-by: bergeouss <noreply@github.com>
Collaborator
|
Closed by the v0.51.4 release in PR #1707 (merged at 4daa238, deployed to production). Live on production: https://github.com/nesquena/hermes-webui/releases/tag/v0.51.4 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
renderMd()JS driver plus the Python mirror.What Changed
static/ui.jsfenced-code matching to capture{3,}backtick opener runs and require\2plus optional extra backticks on close.renderMd()so they include the new shared fence helpers.Why It Matters
<pre><code>block.Fixes #1696
Verification
pytest tests/test_sprint16.py::test_render_md_fenced_code_with_five_backtick_outer_preserves_inner_triples tests/test_sprint16.py::test_render_md_fenced_code_with_four_backtick_outer_preserves_inner_triples tests/test_sprint16.py::test_render_md_fenced_code_three_backtick_path_still_renders_language tests/test_renderer_js_behaviour.py::TestFencedCodeFenceLength tests/test_1325_user_fenced_code.py::TestUserFencedBlocks::test_four_backtick_outer_fence_preserves_inner_triple_fence -q— 7 passedpytest tests/test_sprint16.py tests/test_renderer_js_behaviour.py tests/test_1325_user_fenced_code.py tests/test_issue1438_fence_anchoring.py tests/test_issue1154_fenced_code_leak.py tests/test_issue1618_yaml_json_diff_newline_preserve.py tests/test_issue1446_glued_heading_lift.py tests/test_issue_code_syntax_highlight.py -q— 197 passedgit diff --check— passedenv -u HERMES_CONFIG_PATH /home/michael/.hermes/hermes-agent/venv/bin/python -m pytest tests/ -q— 4484 passed, 2 skipped, 3 xpassed, 1 warning, 8 subtests passed in 407.20sNo screenshots included: this is a renderer parsing fix verified at the rendered-HTML level with the actual
static/ui.jsrenderMd()node driver.Risks / Follow-ups
Model Used
gpt-5.5via Hermes Agent CLI.