Release CR: stage-batch2 — 3-PR low-risk batch (v0.51.120) — Bedrock provider / update past-tag / CORS preflight#2810
Merged
Conversation
Bedrock was silently dropped from the picker because:
1. 'bedrock' absent from _PROVIDER_DISPLAY — group header fell back to
title-cased id; more critically the group fell to the else branch
2. 'bedrock' absent from _PROVIDER_MODELS — else branch has no
auto-detected models, so the group was never appended
3. Fallback env-var detection (hermes_cli unavailable) never checked
AWS_ACCESS_KEY_ID / AWS_SECRET_ACCESS_KEY
Fix:
- Add 'bedrock': 'AWS Bedrock' to _PROVIDER_DISPLAY
- Add static fallback model list to _PROVIDER_MODELS['bedrock'] with
global Anthropic Claude 4.x cross-region inference profile IDs;
live discovery via hermes_cli.models.provider_model_ids('bedrock')
is used first (existing _read_live_provider_model_ids machinery)
- Detect bedrock in env fallback path when both AWS_ACCESS_KEY_ID and
AWS_SECRET_ACCESS_KEY are present
Tests: tests/test_issue2720_bedrock_model_picker.py (5 new tests)
When current_tag == latest_tag, _check_repo_release returned behind=0 and reported 'Up to date' even if master had moved hundreds of commits past the tag. This was visible as Agent: v2026.5.16-593-gedb2d9105 alongside a green 'Up to date' pill in Settings. Run 'git describe --tags --always' after computing behind==0. If the output includes a -N-gSHA suffix the tag is not at HEAD; return None so _check_repo_branch runs and counts the real commit gap via rev-list. When HEAD is exactly on the latest tag the new branch is never taken and behaviour is unchanged. Fixes #2653.
…isk batch) Cherry-picked PRs: - #2786 (munim) — surface bedrock provider in WebUI model picker - #2789 (munim) — update check falls through when HEAD is past latest tag - #2790 (weidzhou) — do_OPTIONS handler for CORS preflight (minimal resubmit of closed #2750) No surface overlap between the 3 PRs.
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release CR — v0.51.120 — stage-batch2 — 3-PR low-risk batch
Second batch from the May 24 sweep. Three contributor PRs that are mechanical, well-tested, and pre-cleared by Opus advisor:
api/config.pyprovider registryapi/updates.pypost-tag fall-throughserver.pydo_OPTIONS handlerCherry-picks
Pre-Opus gate
ast.parseon all touched .pyOpus advisor verdict
What's NOT in this batch
api/streaming.py, deferred to Batch 3 with closer scrutiny