Skip to content

Release CR: stage-batch2 — 3-PR low-risk batch (v0.51.120) — Bedrock provider / update past-tag / CORS preflight#2810

Merged
nesquena-hermes merged 4 commits into
masterfrom
release/stage-batch2
May 24, 2026
Merged

Release CR: stage-batch2 — 3-PR low-risk batch (v0.51.120) — Bedrock provider / update past-tag / CORS preflight#2810
nesquena-hermes merged 4 commits into
masterfrom
release/stage-batch2

Conversation

@nesquena-hermes

Copy link
Copy Markdown
Collaborator

Release CR — v0.51.120 — stage-batch2 — 3-PR low-risk batch

Second batch from the May 24 sweep. Three contributor PRs that are mechanical, well-tested, and pre-cleared by Opus advisor:

PR Author LOC Surface Risk
#2786 @munim +113/-0 api/config.py provider registry low — pure additive, hermes_cli runtime path is source-of-truth, 11 new tests
#2789 @munim +123/-0 api/updates.py post-tag fall-through low — narrows a false "Up to date" signal, 8 new tests cover edge cases
#2790 @weidzhou +9/-0 server.py do_OPTIONS handler low — minimal-split resubmit of closed #2750

Cherry-picks

d7f1514d fix(models): surface bedrock provider in WebUI model picker (#2720)   (#2786)
d04805b0 fix(updates): fall through to branch check when HEAD is past latest tag (#2789)
acda74e5 fix: add do_OPTIONS handler for CORS preflight requests              (#2790)
60eb6f53 Stamp CHANGELOG for v0.51.120

Pre-Opus gate

Check Result
Python ast.parse on all touched .py PASS
Merge-marker grep clean
CHANGELOG placeholder grep clean
Cross-stage surface overlap check clean (config.py / updates.py / server.py — no shared functions)
New regression tests (19) pass in isolation
Full pytest 6267 passed, 7 skipped, 0 failed

Opus advisor verdict

SHIP all three. Severity for any concerns: informational only (no blockers).

What's NOT in this batch

munim and others added 4 commits May 24, 2026 03:42
Bedrock was silently dropped from the picker because:
1. 'bedrock' absent from _PROVIDER_DISPLAY — group header fell back to
   title-cased id; more critically the group fell to the else branch
2. 'bedrock' absent from _PROVIDER_MODELS — else branch has no
   auto-detected models, so the group was never appended
3. Fallback env-var detection (hermes_cli unavailable) never checked
   AWS_ACCESS_KEY_ID / AWS_SECRET_ACCESS_KEY

Fix:
- Add 'bedrock': 'AWS Bedrock' to _PROVIDER_DISPLAY
- Add static fallback model list to _PROVIDER_MODELS['bedrock'] with
  global Anthropic Claude 4.x cross-region inference profile IDs;
  live discovery via hermes_cli.models.provider_model_ids('bedrock')
  is used first (existing _read_live_provider_model_ids machinery)
- Detect bedrock in env fallback path when both AWS_ACCESS_KEY_ID and
  AWS_SECRET_ACCESS_KEY are present

Tests: tests/test_issue2720_bedrock_model_picker.py (5 new tests)
When current_tag == latest_tag, _check_repo_release returned behind=0
and reported 'Up to date' even if master had moved hundreds of commits
past the tag.  This was visible as Agent: v2026.5.16-593-gedb2d9105
alongside a green 'Up to date' pill in Settings.

Run 'git describe --tags --always' after computing behind==0.  If the
output includes a -N-gSHA suffix the tag is not at HEAD; return None so
_check_repo_branch runs and counts the real commit gap via rev-list.

When HEAD is exactly on the latest tag the new branch is never taken and
behaviour is unchanged.

Fixes #2653.
…isk batch)

Cherry-picked PRs:
- #2786 (munim) — surface bedrock provider in WebUI model picker
- #2789 (munim) — update check falls through when HEAD is past latest tag
- #2790 (weidzhou) — do_OPTIONS handler for CORS preflight (minimal resubmit of closed #2750)

No surface overlap between the 3 PRs.
@nesquena-hermes nesquena-hermes merged commit 465b97a into master May 24, 2026
3 checks passed
@nesquena-hermes nesquena-hermes deleted the release/stage-batch2 branch May 24, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants