Release DM — stage-batch23 — 4-PR second hold-bucket pass (v0.51.141)#2992
Merged
Conversation
- Add cursor-acp to _PROVIDER_DISPLAY with label 'Cursor ACP' - Add cursor-acp static model list to _PROVIDER_MODELS - composer-2.5, composer-2, default, cursor-acp
Ensure cursor/composer IDs always resolve via @cursor-acp:, carry the visible picker selection into POST /api/session/new, persist model changes before a session exists, and evict cached agents on model switch. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve supported reasoning efforts per active model/provider and pass that context through /api/reasoning so Composer and other non-configurable models no longer show a misleading effort picker. Co-authored-by: Cursor <cursoragent@cursor.com>
Model picker onchange now calls syncReasoningChip after session model/ provider updates, and dropdown selections pass providerId so duplicate bare model ids resolve to the correct backend capabilities. Co-authored-by: Cursor <cursoragent@cursor.com>
# Conflicts: # CHANGELOG.md # tests/test_webui_prefill_context.py
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release DM / v0.51.141 — stage-batch23 (4 PRs from second hold-bucket pass)
Nathan's correction: "44 holds is too many — go review them again." This is the second deliberate hold-bucket reassessment pass, after DL did the first.
PRs merged
@cursor-acp:routing for subprocess providers, model-aware reasoning chip visibility via new/api/reasoning?model=...&provider=...webui_prefill_messages_scripthook for dynamic prefill context (Joplin/Obsidian/Notion routers) — subprocess with timeout, 256 KiB output cap, error redactionVerification
ast.parseclean on 13 changed .py,node -cclean on all 5 changed JS files-p no:xdist)_ACP_SUBPROCESS_PROVIDERSre-prefix is idempotentshlex.split+shell=False→ no shell injection; semicolon-separated args become literal argvcloseCurrentLiveActivityGroupexists atstatic/ui.js:5461in master, PR only adds CALLSdata-live-activity-current='1'correctly gated, defensive default falseNotes for reviewers
These 4 sat in
holdfor various reasons but on second read were all bounded enough to ship:hermes_clifor full effect but has a heuristic fallback when import fails — degrades gracefullyFollow-up flagged: #2888's subprocess.run buffers stdout in memory for the full 30-s timeout window. A hostile script could spike RSS before the 256 KiB size check fires. Mitigation: opt-in admin config only. Worth converting to streaming read with running byte count in a follow-up PR.
Sitting on top of v0.51.140 (Release DL).