stage-batch33: v0.51.151 / Release DW — SSE reattach + title-lang + composer cap#3038
Merged
Conversation
…orts (#2946) Squash-merged pr-2946 into stage-batch33.
Squash-merged pr-2984 into stage-batch33.
…example Pre-existing failure on master: the test assumed only the broken-proxy /v1/models call would route through fake_urlopen, but get_available_models() also probes the Copilot internal v2 token endpoint (10.0s timeout) and OpenRouter free-tier discovery (8.0s), which now pollute the recorded timeout list. Fix narrows the recorder to the broken-proxy endpoint only. The contract being pinned (broken-proxy probe uses CUSTOM_MODELS_ENDPOINT_TIMEOUT_SECONDS, not the urllib default 10) is unchanged. Caught by stage-batch33 sequential pytest gate.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stage-batch33 — 3-PR mid-risk batch (v0.51.151 / Release DW)
3 contributor PRs, all
MERGEABLE, full pytest 6713 passed / 0 failed / 161s, Opus advisor SHIP-AS-IS.Contents
Verification
Extra fix in this stage
Pre-existing pytest failure on master (
test_named_custom_provider_models_endpoint_network_error_uses_short_timeout) was caught by the full-suite gate. Root cause: the test recorder picked up unrelated background probes (Copilot v2 token, OpenRouter free-tier discovery) that now run duringget_available_models(). Fix narrows the recorder to the broken-proxy endpoint only — the contract being pinned is unchanged. Single test-only commit.Build skew sanity check
All three contributor branches
MERGEABLEagainst current master at the time of staging. Stale-base dual-diff check:Follow-ups to file post-merge
Opus flagged 4 SHOULD-FIX items (none ship-blocking):
_detect_title_languageGerman false-positive surface (api/streaming.py:1381-1394) — common tokens like'session','die','der','das'can trigger German detection on English-with-tech-jargon prompts. Should require ≥3 hits or drop the most-ambiguous tokens.'Alte Session Bilder'German fallback (api/streaming.py:1872-1877) — branch-specific one-off, tech debt._isSessionActivelyViewedgate is broader than the comment claims (static/messages.js:2155-2158) — focus-gated reconnect.Will file as single follow-up issue after release lands.