fix(common): preserve default description for all HTTP exceptions when using options

[malkovitc]

Summary

Preserve default description for all 21 built-in HTTP exceptions when using options object with cause.

Problem

When passing an options object with cause to built-in HTTP exceptions, the default description was lost:

// Before fix: error field would be undefined
throw new BadRequestException('message', { cause: new Error() });
// Response: { message: 'message', error: undefined, statusCode: 400 }

// After fix: error field preserves default
// Response: { message: 'message', error: 'Bad Request', statusCode: 400 }

Solution

Added destructuring default values for description in each exception constructor:

// Before
const { description, httpExceptionOptions } =
  HttpException.extractDescriptionAndOptionsFrom(descriptionOrOptions);

// After  
const { description = 'Bad Request', httpExceptionOptions } =
  HttpException.extractDescriptionAndOptionsFrom(descriptionOrOptions);

Test plan

• Added test that verifies all 21 exceptions preserve their default description
• All existing HttpException tests pass

Related

• Supersedes fix(common): preserve default description for all HTTP exceptions when using options #16006 (had unrelated changes)
• Related to fix(common): preserve default description for teapot exception #15962 (which only fixed ImATeapotException)

Closes #15961

[coveralls]

Pull Request Test Coverage Report for Build 8a135727-6ce0-4aba-a7ae-912360797e37

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 88.939%

---

Totals
Change from base Build f6791497-0812-4887-9ce0-74760514d05b:	0.0%
Covered Lines:	7325
Relevant Lines:	8236

---

💛 - Coveralls

[kamilmysliwiec]

blocked as it introduces a minor breaking change

[malkovitc]

Got it, thanks for the feedback.

Would this be acceptable for the next major version (v12)? I can keep this PR open and rebase when the time comes, or close it and open a fresh one closer to the v12 release - whatever works best for you.

Alternatively, if there's a different approach you'd prefer that could be merged sooner, I'm happy to explore that as well.

[kamilmysliwiec]

yes it will! we can keep it open, no need to create another one