Skip to content

acceptRanges property #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Elte156
Copy link

@Elte156 Elte156 commented Jun 20, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This proposed change exposes an existing Express serve-static option that is currently not available in this @nestjs/serve-static package.

See acceptRanges in the serve-static docs: https://expressjs.com/en/resources/middleware/serve-static.html

Does this PR introduce a breaking change?

  • Yes
  • No

This is an additive change where the native Express serve-static property already exists.

Other information

The areas in which this native Express serve-static property would be used are:

  1. express.static(clientPath, options.serveStaticOptions)
  2. app.use(express.static(clientPath, options.serveStaticOptions));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant