Skip to content

Conversation

@JaroslawPalczynski
Copy link

The code expects lower-case and it does matter on Linux/Unix based systems.

Breaking change

Proposed change

Without this change on Linux/Unix based system you either had working appsettings.development.json without working default .gitignore or vice-versa.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

…pment.json as the code expects lower-case and it does matter on Linux/Unix based systems.
@FrankBakkerNl
Copy link
Contributor

This is not the actual template project, it is the project we use for locally debugging NetDeamon. Also I am not sure if lowercase is correct, maybe we should actually update it to 'Development' in the code-gen

@helto4real
Copy link
Collaborator

This is not the actual template project, it is the project we use for locally debugging NetDeamon. Also I am not sure if lowercase is correct, maybe we should actually update it to 'Development' in the code-gen

We should make it not case sensitive at all maybe

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82%. Comparing base (63eed03) to head (1896e20).

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1340   +/-   ##
====================================
  Coverage    82%     82%           
====================================
  Files       198     198           
  Lines      3892    3892           
  Branches    438     438           
====================================
  Hits       3207    3207           
  Misses      517     517           
  Partials    168     168           
Flag Coverage Δ
unittests 82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants