Skip to content

Support copying windows files with spaces #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support copying windows files with spaces #34

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec31195
Add support for windows paths with spaces
ArtsiomMusin Jul 27, 2017
0e408d2
Convert backslashes to slashes in windows paths
ArtsiomMusin Aug 3, 2017
de0dc07
Merge branch 'master' into support_copying_windows_files_with_spaces
ArtsiomMusin Jul 9, 2018
c92ba07
remove quotes around filename as they mess up the command with latest…
ArtsiomMusin Jul 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/net/scp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,11 +344,15 @@ def scp_command(mode, options)
def start_command(mode, local, remote, options={}, &callback)
session.open_channel do |channel|

if options[:shell]
escaped_file = shellescape(remote).gsub(/'/) { |m| "'\\''" }
command = "#{options[:shell]} -c '#{scp_command(mode, options)} #{escaped_file}'"
if options[:windows_path]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume :windows_path is a new option. Does it means that the remote uses windows style encoding?

command = "#{scp_command(mode, options)} #{remote.gsub('\\', '/')}"
else
command = "#{scp_command(mode, options)} #{shellescape remote}"
if options[:shell]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elsif options[:shell] for readability? 🙂

escaped_file = shellescape(remote).gsub(/'/) { |m| "'\\''" }
command = "#{options[:shell]} -c '#{scp_command(mode, options)} #{escaped_file}'"
else
command = "#{scp_command(mode, options)} #{shellescape remote}"
end
end

channel.exec(command) do |ch, success|
Expand Down