feat: add percentDone support to task update - #25
Merged
Conversation
Add percentDone parameter to the task update subcommand, allowing AI assistants to set task progress percentages (0.0 to 1.0) via the MCP. Changes: - Add percentDone to Zod schema in tasks tool registration - Add percentDone to UpdateTaskArgs interface, analyzeUpdateState, and buildUpdateData in TaskUpdateService - Add test coverage for percentDone in update with all optional fields
20 tasks
Resolve trivial additive conflict in TaskUpdateService.ts analyzeUpdateState: keep both #59's percent_done and #65's project_id previousState tracking. Claude-Session: https://claude.ai/code/session_016D2e7m4RD4YLiVN9Dvp2Vf
|
👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-implements upstream PR #59 by @nahugomez (democratize-technology#59).
Adds a
percentDoneparameter to thevikunja_tasksupdatesubcommand, allowing task progress (0.0-1.0) to be set via the MCP alongside the existing fields.percentDone: z.number().min(0).max(1).optional()to the update subcommand's Zod schema (src/tools/tasks/index.ts)percentDonetoUpdateTaskArgs,analyzeUpdateState(previous-state/affected-fields tracking), andbuildUpdateDatainTaskUpdateService.tspercentDonein the "update task with all optional fields" testTesting
npm run lint- cleannpm run typecheck- cleantests/tools/tasks.test.ts- 107 passed / 32 failed, identical pass/fail split to plainmain(verified via a side-by-side worktree run). The 32 failures are pre-existingbulk-createsubcommand failures unrelated to this change, tracked in the baseline-repair effort (fork PR fix: repair pre-existing test-suite baseline (Wave 0) #12, unmerged). ThepercentDone-specific test passes.Note: repo-wide
npm run test:coveragedoes not fully pass yet onmain(baseline-repair PR #12 in progress, unmerged) — this PR's own changed-area tests are green and introduce no regressions.