allow users to select/deselect network resources #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The marshalled routes are being sent from go client separated by semicolons when provided in the IFace configureInterface callback, but separated by commas on onNetworkChanged call
Now VPNService adds an OnRouteChanged listener to NetworkChangeNotifier, which queues TUN renewal via a looper thread
…lder" This reverts commit f232a6f.
Also remove usage of ServiceAccessor from NetworksFragment
Adapter calls a switch toggle handler defined in NetworksFragment. Fragment, through its view model, reaches all the way to the engine to call the go client functions.
with read/write access on android's context
Network domain stores both its address and a list of resolved ip addresses
It now also takes into consideration resources mapped to domains and its resolved IP addresses in order to check connectivity
So that when toggling a route switch, it won't be in an inconsistent state in case of error from engine
doromaraujo
changed the title
To group android client's file paths parameters, such as configurationFilePath and stateFilePath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds toggle switches on the resources/networks tab to allow users to select/deselect network resources.
When either a network change is detected from the server or a resource is selected/deselected, a new tun file descriptor is obtained from the service side and sent to the engine to be renewed internally with the new route definitions.
The engine is also notified when the user toggles a network resource accordingly.