Bugfix: Make a copy of ipaddress before modifying to not break caching. (#277)

Author: matte4711

plugins/inventory/nb_inventory.py

@@ -831,10 +831,13 @@ def refresh_ipaddresses(self):
             interface_id = ipaddress["interface"]["id"]
             ip_id = ipaddress["id"]
 
-            self.ipaddresses_lookup[interface_id][ip_id] = ipaddress
+            # We need to copy the ipaddress entry to preserve the original in case caching is used.
+            ipaddress_copy = ipaddress.copy()
+
+            self.ipaddresses_lookup[interface_id][ip_id] = ipaddress_copy
 
             # Remove "interface" attribute, as that's redundant when ipaddress is added to an interface
-            del ipaddress["interface"]
+            del ipaddress_copy["interface"]
 
     @property
     def lookup_processes(self):

tests/integration/targets/inventory/files/test-inventory-options-flatten.yml

@@ -3,6 +3,13 @@ api_endpoint: "http://localhost:32768"
 token: "0123456789abcdef0123456789abcdef01234567"
 validate_certs: False
 
+# Use cache on this test to make sure interfaces is tested via the cache
+cache: True
+cache_timeout: 3600
+cache_plugin: jsonfile
+cache_connection: /tmp/inventory_netbox
+
+
 config_context: True
 flatten_config_context: True
 flatten_custom_fields: True