Skip to content

Add support for managing NetBox event rules #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

squirrel289
Copy link

Related Issue

#1261

New Behavior

Added Tasks for managing Event Rules

...

Contrast to Current Behavior

Currently can not manage Event Rules
...

Discussion: Benefits and Drawbacks

Adds ability to manage Netbox event rules through Ansible. Net-new functionality so no risk to backwards compatibility. The support for conditions property required an inelegant approach as I couldn't figure out how to safely modify the existing serialize functionality
...

Changes to the Documentation

Added doc for event_rules module
...

Proposed Release Note Entry

Add support for managing NetBox event rules
...

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

@squirrel289
Copy link
Author

Can anyone give pointers on why unit tests are failing in areas I didn't touch? Having similar problem with all tests failing locally even on a fresh clone. Seems like they are broken in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant