-
Notifications
You must be signed in to change notification settings - Fork 1k
Add rack-types #3026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bastianleicht
wants to merge
8
commits into
netbox-community:master
Choose a base branch
from
bastianleicht:rack-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add rack-types #3026
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bdd2760
feat: add front image
bastianleicht ac14097
feat: startech 4post rack
bastianleicht 6848b69
feat: add digitus DN-19 07U-I-OD
bastianleicht 116b0c6
feat: add digitus DN-19 07U-I-OD
bastianleicht 3ea3e03
Merge remote-tracking branch 'origin/rack-types' into rack-types
bastianleicht dd42e4f
Revert "feat: add front image"
bastianleicht 7bfbe66
fix: change form_factor
bastianleicht 47c164d
Merge branch 'master' into rack-types
bastianleicht File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
--- | ||
manufacturer: Digitus | ||
model: DN-19 07U-I-OD | ||
slug: digitus-dn-19-07u-i-od | ||
width: 19 | ||
u_height: 7 | ||
form_factor: wall-cabinet | ||
description: '[Datasheet](https://www.assmann.com/product-pdf/4016032360971?PL=de)' | ||
starting_unit: 1 | ||
outer_width: 600 | ||
outer_unit: mm | ||
mounting_depth: 450 | ||
weight: 31 | ||
max_weight: 100 | ||
weight_unit: kg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,23 @@ | ||||||||||||||||||||||||||||||
--- | ||||||||||||||||||||||||||||||
manufacturer: Startech | ||||||||||||||||||||||||||||||
model: 4 Post 42U | ||||||||||||||||||||||||||||||
slug: startech-4postrack42 | ||||||||||||||||||||||||||||||
width: 19 | ||||||||||||||||||||||||||||||
u_height: 42 | ||||||||||||||||||||||||||||||
form_factor: 4-post-frame | ||||||||||||||||||||||||||||||
description: Startech 4 Post 42U 19in rack with optional casters | ||||||||||||||||||||||||||||||
starting_unit: 1 | ||||||||||||||||||||||||||||||
outer_width: 600 | ||||||||||||||||||||||||||||||
outer_unit: mm | ||||||||||||||||||||||||||||||
# Adjustable depth, do we want the minimum or maximum depth? | ||||||||||||||||||||||||||||||
# Minimum adjusted depth | ||||||||||||||||||||||||||||||
mounting_depth: 560 | ||||||||||||||||||||||||||||||
# Maximum adjusted depth | ||||||||||||||||||||||||||||||
# mounting_depth: 1017 | ||||||||||||||||||||||||||||||
weight: 38.5 | ||||||||||||||||||||||||||||||
# Different weights between stationary and on casters, which one? | ||||||||||||||||||||||||||||||
# Stationary | ||||||||||||||||||||||||||||||
# max_weight: 600 | ||||||||||||||||||||||||||||||
# Rolling | ||||||||||||||||||||||||||||||
Comment on lines
+12
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify which weight value is intended for use in production or remove the extra commented weight values if they are outdated.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||||||||||||||||||||||||||
max_weight: 360 | ||||||||||||||||||||||||||||||
weight_unit: kg |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider clarifying or removing the commented out mounting_depth values to avoid potential confusion about which depth should be applied.
Copilot uses AI. Check for mistakes.