DRAFT: 14884 Make script running from UI and EventRules consistent in passing params #20596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14884
This makes parameter passing consistent between running a script from the UI and running one from an EventRule. To see add the following script:
Run it in the UI, select an IP Address and then inspect the job data and you should see
Now set up an Event Rule:
Object types: DCIM > Site
Event types: Object created, Object updated
Action type: Script
Script: <script file from above>
Action data: {"ip_address": 3}
(Modify
ip_address
to one in your data). Then go and modify a site and check the output from the new job data and you should see something like:The only part of this second data to check in the
ip_address
as the rest of the data is the Site that triggered the EventRule. Previouslyip_address
would show3
(whatever was in action_data), now it de-references it to the correct object just like running it from the UI does.Note: Moved this to v4.5 milestone as this will be a breaking change from older scripts being run via EventRules.