Fixes #20498: Apply validation regex to URL custom fields #20625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation_regex field was not being enforced for URL type custom fields. This fix adds regex validation in two places: 1. to_form_field() - Applies regex validator to form fields (UI validation) 2. validate() - Applies regex check in model validation (API/programmatic) Note: The original issue reported UI validation only, but this fix also adds API validation for consistency with text field behavior and to ensure data integrity across all entry points.
jnovinger
requested review from
a team and
bctiemann
and removed request for
a team
bctiemann
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20498
The
validation_regexfield was not being enforced for URL type custom fields. This fix adds regex validation in two places:to_form_field()- Applies regex validator to form fields (UI validation)validate()- Applies regex check in model validation (API/programmatic)The original issue reported UI validation only, but this fix also adds API validation for consistency with text field behavior and to ensure data integrity across all entry points.