Skip to content

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Dec 12, 2025

This PR captures some follow-on work for v4.5 FR #20788 that was identified following the initial implementation.

  • CableTermination
    • Add the 'connector' integer field to index terminations on either end of a cable
    • Rename the position integer field to cable_positions (plural) and convert it to an array of integers
  • All cabled models (device components, power feeds, circuit terminations)
    • Introduce the cable_connector integer field
    • Rename the cable_position integer field to cable_positions (plural) and convert it to an array of integers
    • Introduce set_cable_termination() and clear_cable_termination() methods to simplify setting/clearing of cable termination attributes
  • Rework cable profiles to enumerate A & B connectors
  • Standardize cable profile names
  • Add cable profiles for specific cable types
  • Rename migration files
  • Extend cable path test suite

@jeremystretch jeremystretch force-pushed the 20788-cabletermination-connector branch from 4b55f25 to 97b9805 Compare December 14, 2025 20:27
@jeremystretch jeremystretch marked this pull request as ready for review December 15, 2025 13:59
@jeremystretch jeremystretch requested review from a team and jnovinger and removed request for a team December 15, 2025 14:17
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one question and one suggestion: the happy path seems well tested, would be good to confirm the error paths behave as expected too. I think a follow-up housekeeping issue could add tests that explicitly verify validation errors are raised when constraints are violated (e.g., too many terminations for a profile, mismatched connector counts).

@jnovinger jnovinger merged commit 875e3e7 into feature Dec 15, 2025
10 checks passed
@jnovinger jnovinger deleted the 20788-cabletermination-connector branch December 15, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants