-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Additional work for FR #20788 #20973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b55f25 to
97b9805
Compare
jnovinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one question and one suggestion: the happy path seems well tested, would be good to confirm the error paths behave as expected too. I think a follow-up housekeeping issue could add tests that explicitly verify validation errors are raised when constraints are violated (e.g., too many terminations for a profile, mismatched connector counts).
This PR captures some follow-on work for v4.5 FR #20788 that was identified following the initial implementation.
positioninteger field tocable_positions(plural) and convert it to an array of integerscable_connectorinteger fieldcable_positioninteger field tocable_positions(plural) and convert it to an array of integersset_cable_termination()andclear_cable_termination()methods to simplify setting/clearing of cable termination attributes