feat: add python diode otlp client support #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
leoparente
requested review from
MicahParks,
jajeffries and
mfiedorowicz
as code owners
jajeffries
approved these changes
Nov 21, 2025
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new client type,
DiodeOTLPClient, across both the device discovery and worker components. The logic for client initialization now falls back to usingDiodeOTLPClientwhen client credentials are not provided, improving flexibility for different deployment scenarios. Additionally, the main entry points for both components have been updated to reflect these changes, and unused credential checks have been removed.Support for OTLP client initialization
DiodeOTLPClientimport and initialization logic indevice_discovery/client.pyandworker/policy/runner.py, enabling fallback to OTLP client when credentials are missing. [1] [2] [3] [4]Updates to entry point scripts
--diode-client-idand--diode-client-secretarguments indevice_discovery/main.pyandworker/main.py, allowing operation without these credentials. [1] [2]worker/main.pyto ensureDiodeClientis only used when credentials are provided, otherwise falling back to OTLP client.