feat: add metadata support for go backends #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go test coverage
|
leoparente
requested review from
MicahParks,
jajeffries and
mfiedorowicz
as code owners
jajeffries
approved these changes
Nov 21, 2025
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to client configuration and metadata handling for both the network and SNMP discovery services. The main changes include updating how Diode clients are initialized to support OTLP (OpenTelemetry Protocol) connections, passing policy metadata during entity ingestion, and updating dependencies across both services for compatibility and security.
Client initialization and configuration:
network-discovery/cmd/main.goandsnmp-discovery/cmd/main.goto support OTLP connections when client credentials are not provided, allowing more flexible deployment scenarios. [1] [2] [3] [4]Metadata handling for ingestion:
Ingestcalls in bothnetwork-discovery/policy/runner.goandsnmp-discovery/policy/runner.goto pass policy metadata (specifically,policy_name) with each ingestion, improving traceability of ingested data. [1] [2]Dependency updates:
diode-sdk-goand OpenTelemetry dependencies to newer versions in bothnetwork-discovery/go.modandsnmp-discovery/go.mod, ensuring compatibility with the new client features and improving security. [1] [2]Test suite compatibility:
diode.IngestOptionarguments, maintaining compatibility with the new ingestion method signatures. [1] [2] [3] [4]