fix(daemon): log effective model capabilities with provenance - #1584
Merged
Conversation
The startup capability log reported the detector's raw output, so an InputModalities override on a provider that reports a context window but no modality metadata (e.g. vLLM) printed "input=unknown" and looked ignored even though ModelCapabilityResolution had applied it. Log the resolved (effective) values instead, annotated with per-field provenance (configured/detected/default) so an applied override can no longer be misreported. Add a one-line nudge, fired only when input modalities defaulted, pointing operators at Models:Main:InputModalities to enable vision on multimodal models behind metadata-less providers.
Aaronontheweb
enabled auto-merge (squash)
July 5, 2026 18:57
Aaronontheweb
added a commit
that referenced
this pull request
Jul 5, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The startup model-capability log reported the detector's raw output rather than the effective resolved capabilities. When an operator sets an
InputModalitiesoverride on a provider that reports a context window but no modality metadata (e.g. vLLM), the detector returns a non-null partial result, so the log took the "auto-detected" branch and printedinput=unknown— even thoughModelCapabilityResolutionhad correctly applied the override. This made an applied override look ignored and sent at least one operator down a debugging rabbit hole.Change
configured/detected/default). Precedence mirrorsModelCapabilityResolution: configured override > detected > default, so an applied override can no longer be misreported.Models:Main:InputModalitiesto enable vision on multimodal models behind metadata-less providers.Example output now:
Related to the operator-experience side of #1127 (inline overrides on
Models.Mainwere being wiped bydoctor --fix; separately, when present they were being misreported by this log).Test plan
dotnet build src/Netclaw.Daemonclean (0 warnings)dotnet slopwatch analyze— 0 issuesAdd-FileHeaders.ps1 -Verify— all headers presentModelCapabilityResolutiontests 6/6 pass (resolution precedence this log mirrors is already covered)No log-string assertion test added: log output is brittle to assert on and low-value per the repo testing guidelines; the underlying precedence is covered by the resolver tests.