fix(security): remove regex timeout race - #1748
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes regex match timeouts from RegexPromptInjectionDetector and switches to the .NET non-backtracking engine. This change reduces false failures from scheduler delay and keeps linear-time regex work for untrusted input.
Changes:
- Replace per-pattern
matchTimeoutMillisecondsusage withRegexOptions.NonBacktracking. - Centralize regex options into shared constants for text and Unicode patterns.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cause
The Windows runner paused
DiskDestructionRegexfor longer than its one-second timeout.The short test input did not cause excessive backtracking. The timeout measured scheduler delay and threw after the thread resumed.
Failure: https://github.com/netclaw-dev/netclaw/actions/runs/30855724493/job/91826160402
Validation
dotnet test src/Netclaw.Security.Tests/Netclaw.Security.Tests.csproj -c Release --no-restoredotnet test Netclaw.slnx -c Release --no-restoredotnet slopwatch analyzepwsh ./scripts/Add-FileHeaders.ps1 -Verifygit diff --check