Skip to content

Fix Mattermost initial WebSocket connection race - #1986

Merged
Aaronontheweb merged 3 commits into
devfrom
fix/mattermost-initial-connection-wait
Aug 18, 2026
Merged

Fix Mattermost initial WebSocket connection race#1986
Aaronontheweb merged 3 commits into
devfrom
fix/mattermost-initial-connection-wait

Conversation

@Aaronontheweb

Copy link
Copy Markdown
Collaborator

Summary

  • Wait for Mattermost.NET OnConnected before StartAsync returns.
  • Use TimeProvider for the initial connection timeout.
  • Remove the temporary handler after every exit.
  • Add offline tests for success, timeout, cancellation, and start failure.

This PR supersedes #1974.
It preserves commit credit for @TsengSR.

Fixes #1517

Validation

  • Release build: passed
  • New connection gate tests: 4 passed
  • Mattermost lifecycle tests: 11 passed
  • Full Netclaw.Actors.Tests suite: passed
  • Real Mattermost container handshake: passed
  • Slopwatch: passed with no new violations
  • File header check: passed
  • Format check: passed

Behavioral evals did not run. This transport-only fix does not affect an eval surface.

@Aaronontheweb Aaronontheweb added bug Something isn't working channels Discord, Slack, and other channels. reliability Retries, resilience, graceful degradation tests All issues related to testing, quality assurance, and smoke testing. labels Aug 18, 2026
@Aaronontheweb
Aaronontheweb enabled auto-merge (squash) August 18, 2026 13:43
@Aaronontheweb
Aaronontheweb disabled auto-merge August 18, 2026 15:03
@Aaronontheweb
Aaronontheweb merged commit 4399726 into dev Aug 18, 2026
23 checks passed
@Aaronontheweb
Aaronontheweb deleted the fix/mattermost-initial-connection-wait branch August 18, 2026 15:03
@Aaronontheweb Aaronontheweb mentioned this pull request Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working channels Discord, Slack, and other channels. reliability Retries, resilience, graceful degradation tests All issues related to testing, quality assurance, and smoke testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mattermost channel integration stuck in reconnect loop

2 participants