fix: keep installed binaries on full reset (#2085) - #2086
Open
Aaronontheweb wants to merge 3 commits into
Open
Conversation
| File.WriteAllText(_paths.NetclawConfigPath, "{}"); | ||
| File.WriteAllText(_paths.SqliteDbPath, "db"); | ||
| // bin/ holds the installed binaries; a full reset must purge data but keep it. | ||
| var binaryPath = Path.Combine(_paths.BinDirectory, "netclaw"); |
Aaronontheweb
commented
Aug 29, 2026
Aaronontheweb
left a comment
Collaborator
Author
There was a problem hiding this comment.
Small PR but have some nits
| { | ||
| File.WriteAllText(_paths.NetclawConfigPath, "{}"); | ||
| File.WriteAllText(_paths.SqliteDbPath, "db"); | ||
| // bin/ holds the installed binaries; a full reset must purge data but keep it. |
| foreach (var entry in Directory.GetDirectories(_paths.BasePath)) | ||
| { | ||
| var name = Path.GetFileName(entry); | ||
| if (string.Equals(name, "bin", StringComparison.OrdinalIgnoreCase)) |
Collaborator
Author
There was a problem hiding this comment.
is there a way to fix this without using a magic string here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full reset in
netclaw initdeletes the installed binaries, so it bricked the CLI and every laternetclawcall failed with "No such file or directory".Changes
InitExistingInstallViewModel.RunResetAsyncFull scope now enumeratesBasePathand deletes every entry exceptbin/, plus root-level files (netclaw.db,netclaw.pid,netclaw.lock), instead of deleting the whole base directory.FullReset_AfterBothConfirmations_DeletesEverythingto seed abin/dir and assert it survives while config and the memory DB are purged. It previously asserted the whole base directory was gone, so the binary wipe was invisible to the suite.Fixes #2085.