-
Notifications
You must be signed in to change notification settings - Fork 8
Tutorial Maker V2: In-Progress Edits #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hey @nbriz, would you mind taking a look at the keyframe, spotlight, and widget UI so far and see if you have any feedback on whether it is intuitive? There is fine-tuning that I want to do to the UI but I just wanted to get your thoughts on what I have so far so if I need to pivot I can earlier than later. Please note the widget dropdown and widget maker UI is in-progress and missing most of the actual functionality. The keyframe editing and spotlight should be working, if you notice any bugs, please let me know. I am sure there are many. But don't feel that you need to test for bugs yet, we can do that once I have everything down since things are changing a lot. |
|
@Cthomp7 sorry for delay on this, the new quarter started last week && i got sucked into that. finally had a chance to pull this down + check it out && it looks FANTASTIC!!!! u've done a great job with the UI, such a great use of space too! in terms of UI i have no notes, keep going in this direction! in terms of functionality, one tiny note: when we add a new keyframe i think it should automatically open the details view (similar to how it does when u click on an existing keyframe) so u don't have to click "new keyframe" && then click the actual keyframe to view it (it should probably also auto-close the keyframe/keylog drop-down list at that point) in terms of bugs, something's up with the spotlight, when i edit a keyframe && then play it back (by playing the tutorial && letting it get to that frame) doesn't seem to properly spotlight the line i chose (instead all the lines go dark), && if i jump to that kehyframe using the keyframe timeline nothing gets spotlit, they all stay bright (it does work when i click preview though)... this might be an issue in the actual HVP playback (not the Tutorial Maker) i can look into that, let me know. what are ur thoughts on progress/timeline? i'm nearly finished with the JS learning guide updates, at which point the only thing remaining before launch is the new What is Code tutorial (which i was gonna make with this once it's finished)... the rest of the TODO list i'm gonna work on after launch (otherwise we'll never get this out ^__^) |
|
@nbriz No worries, glad you like the direction of the Ui design so far. I will definitely fix the first issue and for the keyframe and spotlight bug I might fix that after getting this bulk stuff in, so if you want to investigate feel free to otherwise I can afterwards. timelineRegarding timeline, this week is definitely tough since I have some other urgent tasks to complete before Friday. But hopefully this weekend I will have some time. What is left on the docket is.. Ability to save tutorials: Ability to Create/Edit Widgets: Ability to upload assets: Ability to Create/Edit Keylogs: The first three tasks shouldn't take too much of my time, the last one (keylogs) will probably be the most consuming. I could probably have the first three done end of the weekend. Would you be able to help with the keylog functionality? I can always go back and revise any UI if needed. Just let me know. |
|
thnx @Cthomp7 |
|
@nbriz awesome thank you! I just double-checked and everything on this branch is up to date. |
|
@Cthomp7 i'm on campus next couple days (so likely wont get to it till later in the week) i'll pull this branch before working on anything though, so if u keep it up to date with changes on ur end, hopefully we can avoid any conflicts |
Added:
zipper.downloadto download up-to-date keyframes and keylogsOther: