fix(deps): upgrade 23 outdated dependencies - #7019
Conversation
6413ed5 to
a964464
Compare
There's some sort of undocumented breaking visual change that's messing with snapshot tests.
a964464 to
8da2278
Compare
| }, | ||
| "dependencies": { | ||
| "@bugsnag/js": "7.25.0", | ||
| "@bugsnag/js": "8.2.0", |
There was a problem hiding this comment.
nothing relevant: https://github.com/bugsnag/bugsnag-js/blob/v8.0.0/UPGRADING.md
| "@netlify/redirect-parser": "14.5.0", | ||
| "@netlify/zip-it-and-ship-it": "9.42.4", | ||
| "@octokit/rest": "20.1.1", | ||
| "@octokit/rest": "21.1.0", |
There was a problem hiding this comment.
changed to esm: https://github.com/octokit/rest.js/releases/tag/v21.0.0
| "backoff": "2.5.0", | ||
| "better-opn": "3.0.2", | ||
| "boxen": "7.1.1", | ||
| "boxen": "8.0.1", |
There was a problem hiding this comment.
now requires node 18 (we already do): https://github.com/sindresorhus/boxen/releases/tag/v8.0.0
| "commander": "10.0.1", | ||
| "comment-json": "4.2.5", | ||
| "configstore": "6.0.0", | ||
| "configstore": "7.0.0", |
There was a problem hiding this comment.
now requires node 18 (we already do): https://github.com/sindresorhus/configstore/releases/tag/v7.0.0
| "from2-array": "0.0.4", | ||
| "fuzzy": "0.1.3", | ||
| "get-port": "5.1.1", | ||
| "get-port": "7.1.0", |
There was a problem hiding this comment.
now requires node 18 (we require 18) and uses esm, plus irrelevant changes: https://github.com/sindresorhus/get-port/releases
| "https-proxy-agent": "7.0.6", | ||
| "inquirer": "6.5.2", | ||
| "inquirer-autocomplete-prompt": "1.4.0", | ||
| "inquirer": "9.1.0", |
There was a problem hiding this comment.
- inquirer 7 drops node 6: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%407.0.0
- inquirer 8 drops node 10: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%408.0.0
- inquirer 9 becomes esm: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%409.0.0
I had to pin to 9.0.0 because there were undocumented arguably-breaking changes to the output and updating our snapshot tests was turning into a can of worms.
There was a problem hiding this comment.
To be clear, the latest is 12. 10, 11, and 12 should be easy enough in theory, if we stick with inquirer:
- 10 no longer needs
@types/inquirer: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%4010.0.0 - 11 makes a styling change: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%4011.0.0
- 12 won't matter: https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%4012.0.0
| "inquirer": "6.5.2", | ||
| "inquirer-autocomplete-prompt": "1.4.0", | ||
| "inquirer": "9.1.0", | ||
| "inquirer-autocomplete-prompt": "3.0.1", |
There was a problem hiding this comment.
changed to esm and supports inquirer >= 9: https://github.com/mokkabonna/inquirer-autocomplete-prompt/releases
There was a problem hiding this comment.
ugh, after going down a rat hole I ended backing out of the inquirer-autocomplete-prompt upgrade since I couldn't figure what was changing and why... which in turn forced me to downscale the inquirer upgrade to v8 😞
| "locate-path": "7.2.0", | ||
| "lodash": "4.17.21", | ||
| "log-symbols": "6.0.0", | ||
| "log-symbols": "7.0.0", |
There was a problem hiding this comment.
not really major, should just become smaller: https://github.com/sindresorhus/log-symbols/releases
| "prettyjson": "1.2.5", | ||
| "pump": "3.0.2", | ||
| "raw-body": "2.5.2", | ||
| "raw-body": "3.0.0", |
There was a problem hiding this comment.
lousy release notes but doesn't seem actually major... https://github.com/stream-utils/raw-body/blob/master/HISTORY.md
| "raw-body": "3.0.0", | ||
| "read-package-up": "11.0.0", | ||
| "readdirp": "3.6.0", | ||
| "readdirp": "4.1.1", |
There was a problem hiding this comment.
requires node 14, removes glob support (we weren't using them), and changes some exports (I updated our imports): https://github.com/paulmillr/readdirp/releases/tag/4.0.0
| "unixify": "1.0.0", | ||
| "update-notifier": "7.3.1", | ||
| "uuid": "9.0.1", | ||
| "uuid": "11.0.5", |
There was a problem hiding this comment.
requires node 16, adds types (no longer need @types/uuid): https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md
| "@types/ws": "8.5.14", | ||
| "@vitest/coverage-v8": "1.6.0", | ||
| "c8": "9.1.0", | ||
| "c8": "10.1.3", |
There was a problem hiding this comment.
requires node 18 (so do we): https://github.com/bcoe/c8/releases/tag/v10.0.0
| "husky": "8.0.3", | ||
| "is-ci": "3.0.1", | ||
| "fs-extra": "11.3.0", | ||
| "husky": "9.1.7", |
There was a problem hiding this comment.
requires node 18 (so do we), technically no other breaking changes but I updated to the new format: https://github.com/typicode/husky/releases/tag/v9.0.1
| "is-ci": "3.0.1", | ||
| "fs-extra": "11.3.0", | ||
| "husky": "9.1.7", | ||
| "is-ci": "4.1.0", |
There was a problem hiding this comment.
removes support for very minor CI platforms: https://github.com/watson/is-ci/releases/tag/v4.0.0
| "eslint-plugin-sort-destructure-keys": "2.0.0", | ||
| "eslint-plugin-workspace": "file:./tools/lint-rules", | ||
| "form-data": "4.0.1", | ||
| "fs-extra": "11.2.0", |
There was a problem hiding this comment.
unrelated but this was easy to get rid of so I did (just a dev dep, so won't help with package weight, but still)
6f9ed61 to
b4b7532
Compare
It looks like there's some sort of change in inquirer-autocomplete-prompt and it's a can of worms to troubleshoot. This in turn prevents upgrading inquirer past v8.
b4b7532 to
2eb463a
Compare
| "http-proxy-middleware": "2.0.7", | ||
| "https-proxy-agent": "7.0.6", | ||
| "inquirer": "6.5.2", | ||
| "inquirer": "8.0.0", |
| "nock": "13.5.6", | ||
| "husky": "9.1.7", | ||
| "is-ci": "4.1.0", | ||
| "nock": "14.0.0", |
There was a problem hiding this comment.
requires node 18 (like we do): https://github.com/nock/nock/releases/tag/v14.0.0
This reverts commit 055a7b0.
Summary
(Pulling the
commanderupgrade out of #7008 as it's turning into a can of worms.)I carefully reviewed all the release notes for all of these. Many of the major bumps are just dropping support for older versions of node.js we already don't support. For anything relatively easy, I made the necessary changes. I punted on the more involved upgrades.