Skip to content

fix(deps): replace tabtab with (smaller!) maintained fork #7057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

serhalp
Copy link
Member

@serhalp serhalp commented Feb 24, 2025

Summary

tabtab doesn't appear to be maintained, but pnpm has been actively maintaining a fork.

Accidentally closes #3972. :)

await fs.readFile(zshConfigFilepath, 'utf8', (err, data) => {
fs.readFile(zshConfigFilepath, 'utf8', (_err, data) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the unrelated changes, just fixing some minor warnings as I encounter them

Copy link

github-actions bot commented Feb 24, 2025

📊 Benchmark results

Comparing with 0b9d4f5

  • Dependency count: 1,197 ⬇️ 1.67% decrease vs. 0b9d4f5
  • Package size: 298 MB ⬇️ 6.49% decrease vs. 0b9d4f5
  • Number of ts-expect-error directives: 729 (no change)

@serhalp serhalp marked this pull request as ready for review February 24, 2025 22:12
@serhalp serhalp requested a review from a team as a code owner February 24, 2025 22:12
@serhalp serhalp changed the title fix(deps): replace tabtab with maintained fork fix(deps): replace tabtab with (smaller!) maintained fork Feb 24, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I manually tested this command for good measure

Copy link
Contributor

@ndhoule ndhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@serhalp serhalp merged commit 1ddae37 into main Feb 25, 2025
49 checks passed
@serhalp serhalp deleted the fix/replace-tabtab branch February 25, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(deps): find a replacement to the tabtab dependency, so we can upgrade inquirer
2 participants