build: relocate site netlify.toml to site/ directory #7090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the site
netlify.toml
to thesite/
directory.Previously, the site-build workflow went like this:
npm install
at the root of the project (by default)postinstall
hook triggered a CLI buildnetlify.toml#build.command
, which:npm install
againstdocs/package.json
npm install
andnpm run build
steps)To make this change, I modified the logic to:
site/
directory and executesnpm install
site/netlify.toml#build.command
enters the root and preps the CLI, then returns to thedocs/
directoryIn this way, the site's dependency on the CLI's source is more clear--we assume nothing about the state of the root directory before building the docs site.
Some other noteworthy changes here:
dist
directory. I modified them to be transpiled at runtime and to import fromsrc
.site/netlify/functions
. Doing so also let me move a dependency that was only used on the site (@bugsnag/js
) out of the root, which slims the CLI's dependency tree.site:
tasks from the top-levelpackage.json
. (I left thedocs
task, though.)docs
. The site is refusing to build onmain
right now anyway, so I already made that change.