refactor: use LocalState from @netlify/dev-utils #7454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keanu-a
changed the title
serhalp
reviewed
Jul 23, 2025
src/utils/cli-state.ts
Outdated
There was a problem hiding this comment.
👍🏼 appears to be identical, so no need for any other changes
| import process from 'process' | ||
|
|
||
| import { deleteProperty, getProperty, hasProperty, setProperty } from 'dot-prop' | ||
| import { findUpSync } from 'find-up' |
There was a problem hiding this comment.
looks like this is the only use of find-up, so we can remove it!
There was a problem hiding this comment.
Ah it's the only use of findUpSync but other files do use findUp from the find-up package still 😅
Ex: https://github.com/netlify/cli/blob/keanualoua/ex-367-use-localstate-in-netlifydev-utils/src/commands/base-command.ts
There was a problem hiding this comment.
wtf, github search lied to me earlier, but now it's showing all the results. my bad!
There was a problem hiding this comment.
All good! It does lie sometimes 🤣
serhalp
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #EX-367
Replaced all usages of
CLIStatewithLocalStatefrom@netlify/dev-utils. Deletedcli-state.jsas no longer used.Ref: https://github.com/netlify/primitives/blob/main/packages/dev-utils/src/lib/local-state.ts#L27
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)