-
Notifications
You must be signed in to change notification settings - Fork 41
Remove uneeded pip deps #2039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove uneeded pip deps #2039
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
==========================================
- Coverage 71.60% 71.56% -0.04%
==========================================
Files 80 80
Lines 10653 10653
==========================================
- Hits 7628 7624 -4
- Misses 2623 2627 +4
Partials 402 402
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
59660d7
to
21d604f
Compare
21d604f
to
ddd544d
Compare
@OlivierCazade : sounds like there are 4 unneeded python dependencies for the bundle build |
alternatively we could also throw python away and use something else ..... |
I think most pip deps are not needed ... let's check konflux build to make it sure