Skip to content

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 25, 2025

I think most pip deps are not needed ... let's check konflux build to make it sure

Copy link

openshift-ci bot commented Sep 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign msherif1234 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.56%. Comparing base (20ae0f3) to head (ddd544d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2039      +/-   ##
==========================================
- Coverage   71.60%   71.56%   -0.04%     
==========================================
  Files          80       80              
  Lines       10653    10653              
==========================================
- Hits         7628     7624       -4     
- Misses       2623     2627       +4     
  Partials      402      402              
Flag Coverage Δ
unittests 71.56% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak jotak force-pushed the clean-pip-deps branch 2 times, most recently from 59660d7 to 21d604f Compare September 25, 2025 10:05
@jotak
Copy link
Member Author

jotak commented Sep 25, 2025

@OlivierCazade : sounds like there are 4 unneeded python dependencies for the bundle build
I haven't found an easy way to clean/regenerate the requirement file, other than check manually one by one removing dependencies.. would be good to automate that; do you remember how you created it in the first place?

@jotak jotak marked this pull request as ready for review September 25, 2025 10:26
@jotak
Copy link
Member Author

jotak commented Sep 25, 2025

alternatively we could also throw python away and use something else .....

@jotak jotak added the needs-review Tells that the PR needs a review label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Tells that the PR needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant