-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add input_output_map and multi-vote #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Graham Neubig <[email protected]>
Co-authored-by: Graham Neubig <[email protected]>
…o input_output_map
neubig
approved these changes
Aug 8, 2023
I approve, with one small suggested change! |
Co-authored-by: Graham Neubig <[email protected]>
…o input_output_map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This one is decoupled from #196.
construct_input_output_map
andapply_multi_vote_to_construct_generated_dataset
with corresponding unit tests indataset_generator_with_filter_test.py
.mock_batch_openai_response
tomock_batch_openai_response_with_identical_completions
. Because later, we need new mock functions calledmock_batch_openai_response_with_different_completions
andreset_mock_batch_openai_response_with_different_completions
.dataset_tool
in test_helper, which consists ofare_datasets_identical
andare_dataset_dicts_identical
. I also use these two functions in the unit tests ofdataset_processor
in the final PR.References
Blocked by