Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add input_output_map and multi-vote #199

Merged
merged 366 commits into from
Aug 11, 2023
Merged

add input_output_map and multi-vote #199

merged 366 commits into from
Aug 11, 2023

Conversation

zhaochenyang20
Copy link
Collaborator

Description

This one is decoupled from #196.

  1. I add construct_input_output_map and apply_multi_vote_to_construct_generated_dataset with corresponding unit tests in dataset_generator_with_filter_test.py.
  2. I change mock_batch_openai_response to mock_batch_openai_response_with_identical_completions. Because later, we need new mock functions called mock_batch_openai_response_with_different_completions and reset_mock_batch_openai_response_with_different_completions.
  3. I add dataset_tool in test_helper, which consists of are_datasets_identical and are_dataset_dicts_identical. I also use these two functions in the unit tests of dataset_processor in the final PR.

References

  • NA

Blocked by

  • NA

@zhaochenyang20 zhaochenyang20 requested a review from neubig August 8, 2023 21:29
prompt2model/dataset_generator/openai_gpt.py Outdated Show resolved Hide resolved
@neubig
Copy link
Collaborator

neubig commented Aug 8, 2023

I approve, with one small suggested change!

@zhaochenyang20 zhaochenyang20 changed the base branch from add_new_member_variables to stress_original_examples August 11, 2023 03:51
Base automatically changed from stress_original_examples to main August 11, 2023 12:57
@zhaochenyang20 zhaochenyang20 merged commit 82552be into main Aug 11, 2023
@zhaochenyang20 zhaochenyang20 deleted the input_output_map branch August 11, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants