Skip to content

[Transform] Construct on GPU, cache on CPU #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jul 7, 2025
Merged

[Transform] Construct on GPU, cache on CPU #352

merged 31 commits into from
Jul 7, 2025

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Jun 11, 2025 •
edited
Loading

Purpose

  • Enable construction of large Hadamard matrices, whose large sizes require construction on the execution device (GPU)

Prerequisites

Changes

  • Extend ParameterizedDefaultDict to pass keyword arguments to factory function
  • Modify hadamard factories to construct hadamards on the execution device (GPU), but cache them on the offload device (CPU)
  • Add frozendict dependency for safer defaulting

Testing

  • Transform correctness and memory management tests pass

kylesayrs added 13 commits June 11, 2025 13:45
@kylesayrs
use hadamards database file
a27db62 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
try manifest
ce63955 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
try setup, update hadamards list
7ae5863 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
fix setup
67675c3 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
add docstrings, cleanup
f061db9 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
fix setup, thank you @dbarbuzzi
4a84ce1 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
remove numpy, add tests
cde1066 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
solidify dtype, add gpu tests
1ba6195 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
fix docstring
c373345 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
add device option
fbaf47a 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
construct on execution device, cache on offload device
5a887f4 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
save construction device changes for later
310fe6d 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
construct on execution device, cache on offload device
b715329
@kylesayrs kylesayrs changed the base branch from main to kylesayrs/extend-hadamard June 11, 2025 21:57
@kylesayrs kylesayrs mentioned this pull request Jun 11, 2025
Merged
kylesayrs added 2 commits June 11, 2025 18:04
@kylesayrs
cite nja sloane
249323c 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
Merge branch 'kylesayrs/extend-hadamard', remote-tracking branch 'ori…
1823af4 
…gin' into kylesayrs/transform_construct_cache_device
@kylesayrs kylesayrs marked this pull request as ready for review June 11, 2025 22:08
@kylesayrs kylesayrs mentioned this pull request Jun 12, 2025
Merged
brian-dellabetta
brian-dellabetta previously approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything makes sense to me but the new method on ParametrizedDefaultDict, left a comment

Base automatically changed from kylesayrs/extend-hadamard to main June 13, 2025 16:44
@dsikka dsikka dismissed brian-dellabetta’s stale review June 13, 2025 16:44

The base branch was changed.

dsikka
dsikka reviewed Jul 3, 2025
View reviewed changes
kylesayrs added 2 commits July 7, 2025 11:04
@kylesayrs
use factory_kwargs
500af9b 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
add frozen dict to deps
8e36540 
Signed-off-by: Kyle Sayers <[email protected]>
brian-dellabetta
brian-dellabetta previously approved these changes Jul 7, 2025
View reviewed changes
dsikka
dsikka previously approved these changes Jul 7, 2025
View reviewed changes
@kylesayrs
fix missing import
282ba31 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs dismissed stale reviews from dsikka and brian-dellabetta via 282ba31 July 7, 2025 16:36
@kylesayrs kylesayrs merged commit 6c63987 into main Jul 7, 2025
1 check passed
@kylesayrs kylesayrs deleted the kylesayrs/transform_construct_cache_device branch July 7, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@dsikka dsikka dsikka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylesayrs @brian-dellabetta @dsikka